Copy local theme overrides from Control
to Window
#69353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69308. This is probably the last missing feature from
Window
s related to theming.While this PR manipulates a lot of lines, it doesn't do anything particularly smart. Most of the code is just copied and adapted from
control.h/cpp
. I've renamed some internal members inControl
as well, for consistency. And moved some things inWindow
for better grouping. Documentation should also be in sync now.godot.windows.editor.dev.x86_64_2022-11-29_22-57-09.mp4
PS. My plan is to reduce this duplicated code significantly in future, when I can work on the first-class theme properties. But for now this will do.