Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StringName documentation to match String's #69821

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Dec 9, 2022

After #68747 was merged, the descriptions used by the StringName documentation quickly became outdated after #68838. This PR updates the descriptions to be essentially identical.

@Mickeon Mickeon requested a review from a team as a code owner December 9, 2022 19:04
@YuriSizov YuriSizov added this to the 4.0 milestone Dec 9, 2022
@akien-mga akien-mga merged commit ae86d90 into godotengine:master Dec 9, 2022
@akien-mga
Copy link
Member

Thanks!

Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review.

The examples for StringName are actually using Strings, is that intended?

doc/classes/StringName.xml Show resolved Hide resolved
doc/classes/StringName.xml Show resolved Hide resolved
@Mickeon
Copy link
Contributor Author

Mickeon commented Dec 10, 2022

I need to keep these in mind for a later general tweak around the updated docs...

@rune-scape
Copy link
Contributor

thank you for cleaning up after me 😅

@Mickeon Mickeon deleted the the-future-is-now-old-man branch February 11, 2023 23:06
Mickeon added a commit to Mickeon/godot that referenced this pull request Feb 14, 2023
JeffVenancius pushed a commit to JeffVenancius/godot that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants