Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix GLES 2 SpotLight bug with shadow filter mode #69826

Merged
merged 1 commit into from
Dec 13, 2022
Merged

[3.x] Fix GLES 2 SpotLight bug with shadow filter mode #69826

merged 1 commit into from
Dec 13, 2022

Conversation

norrath-hero
Copy link

@norrath-hero norrath-hero commented Dec 9, 2022 •
edited by akien-mga
Loading

#69759 after this patch

shadow filter mode: disabled
win7x64-2022-12-10-04-05-09

shadow filter mode: pcf5
win7x64-2022-12-10-04-05-27

shadow filter mode: pcf13
win7x64-2022-12-10-04-05-38

#54343 after this patch

shadow filter mode: disabled
pcf_disabled

shadow filter mode: pcf5
pcf5

shadow filter mode: pcf13
pcf13

#25526 after this patch
test

@norrath-hero norrath-hero requested a review from a team as a code owner December 9, 2022 20:08
@Chaosus Chaosus added this to the 3.x milestone Dec 9, 2022
This was referenced Dec 9, 2022
Closed
Closed
clayjohn
clayjohn reviewed Dec 10, 2022
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can delete the definition of SAMPLE_SHADOW_TEXEL_PROJ now that it is no longer used

drivers/gles2/shaders/scene.glsl Outdated Show resolved Hide resolved
@norrath-hero norrath-hero requested review from Calinou and clayjohn and removed request for Calinou December 10, 2022 06:20
@clayjohn clayjohn modified the milestones: 3.x, 3.6 Dec 10, 2022
@clayjohn clayjohn added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 10, 2022
clayjohn
clayjohn approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@akien-mga akien-mga merged commit 5797b2f into godotengine:3.x Dec 13, 2022
@akien-mga
Copy link
Member

akien-mga commented Dec 13, 2022 •
edited
Loading

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga
Copy link
Member

Cherry-picked for 3.5.2.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 13, 2022
@akien-mga akien-mga mentioned this pull request Dec 13, 2022
Closed
@norrath-hero norrath-hero restored the 3.x branch December 13, 2022 14:22
@akien-mga akien-mga changed the title Fix GLES 2 Spotlight bug Fix GLES 2 SpotLight bug with shadow filter mode Dec 14, 2022
@akien-mga akien-mga changed the title Fix GLES 2 SpotLight bug with shadow filter mode [3.x] Fix GLES 2 SpotLight bug with shadow filter mode Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou left review comments

@norrath-hero-cn norrath-hero-cn norrath-hero-cn left review comments

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
3.x release management
Status: Done
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
6 participants
@norrath-hero @akien-mga @Calinou @clayjohn @norrath-hero-cn @Chaosus