LSP: Improve handling of file URI scheme #69960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes godotengine#63205. (cherry picked from commits 3fa943f, 42a16ef and 2ff69d6)
akien-mga
added
bug
topic:gdscript
topic:editor
cherrypick:3.5
|
Thank you very much for fixing this issue. I tried to implement the feedback in #64524 but I was in over in my head. |
|
@akien-mga
|
|
Cherry-picked for 3.5.2. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file:///path is used for script reloading #63205.Backport of the following PRs:
LSP: Sanitizes protocol URI
file:///c%3Ain file path #63388LSP: Fixing URI and path formating problems on unix systems regression from #63388 #64099
LSP: root_uri will fail to replace due to no uri_decoding #63388 #64130
Supersedes Fix file URI format for language server #64524.
@A-Lamia Could you help test and ensure that this works OK?