Remove mesh bone_aabbs as they are not used anywhere and calculating them is a pain

[clayjohn]

Fixes #56458 once and for all

Tested with MRPs from: #56458, #69516, and #64416 (comment)

The bone_aabbs array was added in 449df8f and was only used in one place. That one place was removed in #44649 and since then bone_aabbs has never been used. We do however, use surface[i].bone_aabbs.

There is no point in merging together the various bone_aabbs as the bone indices don't necessarily correlate with each other at all. At best this resulted in a fairly chaotic array of AABBs.

I will need to discuss with @reduz, but my guess behind the original intention of this code was that it should expand the mesh->aabb to cover all the individual bone AABBS. If that is the case, then we will be better off doing that during the original calculation of the bone_aabbs in the RenderingServer

[fire]

Your reasoning makes sense, and if nothing is using it... it follows to remove it.

[reduz]

Unless I am misunderstanding something, Bone AABBs are used for updating the AABB of a mesh instance when a skeleton using it changes. This in itself should probably not be the default behavior due to performance, but should be optional for games that really need this AABB precision (had a couple in the past). If bone AABBs are not supplied, then the regular mesh AABB should be used (and/or a custom override).

[clayjohn]

Unless I am misunderstanding something, Bone AABBs are used for updating the AABB of a mesh instance when a skeleton using it changes. This in itself should probably not be the default behavior due to performance, but should be optional for games that really need this AABB precision (had a couple in the past). If bone AABBs are not supplied, then the regular mesh AABB should be used (and/or a custom override).

@reduz That code uses the per-surface bone_aabbs, not the merged mesh->bone_aabbs which is all of the surface's bone_aabbs merged together

[akien-mga]

This is unused code currently so the removal makes sense.

[akien-mga]

Thanks!