Move remote debug buttons to a single menu. #70701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
force-pushed
the
remote_debug_menu
branch
from
647f3c5
to
5a8b5a0
Compare
akien-mga
reviewed
Jan 13, 2023
bruvzg
force-pushed
the
remote_debug_menu
branch
from
5a8b5a0
to
9334fb9
Compare
YuriSizov
reviewed
Jan 13, 2023
YuriSizov
reviewed
Jan 13, 2023
bruvzg
force-pushed
the
remote_debug_menu
branch
from
9334fb9
to
5406b00
Compare
|
Thanks! |
|
This is confusing when no remote debugs are configured. The button turns blue when clicked, but nothing else happens. Other nearby buttons are disabled or give a warning when you click them but something isn't configured properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #63312 and #70662 editor toolbar is getting too cluttered (if multiple remote debug options are enabled), so it makes sense to group all remote debug items in a single menu button.
Before:
After:
