Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_path() is not working when files are opend with open_compressed #70726

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Fix get_path() is not working when files are opend with open_compressed #70726

merged 1 commit into from
Jan 10, 2023

Conversation

heppocogne
Copy link
Contributor

@heppocogne heppocogne commented Dec 30, 2022 •
edited
Loading

This commit fixes #70712.
And also fixed get_path_absolute() in the same way.

Note that there's the same problem in v3.5.1. If neccessary, I will also create another PR for v3.5 branch.

@heppocogne heppocogne requested a review from a team as a code owner December 30, 2022 01:27
@heppocogne
Fix get_path() is not working when files are opend with `open_compr…
ea11ffc 
…essed`

And also fixed `get_absolute_path()` in the same way
@Chaosus Chaosus added this to the 4.0 milestone Jan 1, 2023
@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Jan 10, 2023
akien-mga
akien-mga approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I'll check a bit closer before merging.

Edit: Most other FileAccess* implementations in core/io also don't implement those (though I don't know if it's valid for all). But it makes sense to start here with FileAccessCompressed.

@akien-mga akien-mga merged commit 0231b4a into godotengine:master Jan 10, 2023
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 11, 2023
@akien-mga
Copy link
Member

Cherry-picked for 3.5.2.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

FileAccess get_path contains an empty string when opened with compression.
3 participants
@heppocogne @akien-mga @Chaosus