Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up EditorFileSystem script parsing #71628

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Clean up EditorFileSystem script parsing #71628

merged 1 commit into from
Jan 19, 2023

Conversation

reduz
Copy link
Member

@reduz reduz commented Jan 18, 2023

  • Optimize only update modified/added/removed files.
  • Clean up documentation parsing.

@reduz reduz requested review from a team as code owners January 18, 2023 16:33
@KoBeWi KoBeWi added this to the 4.0 milestone Jan 18, 2023
@adamscott
Copy link
Member

ScriptLanguage::get_global_class_name() doesn't seem to be called by your new code. How does it make sure that a script loaded is meant to be global?

@reduz
Copy link
Member Author

reduz commented Jan 18, 2023

@adamscott this has been scanned and cached in the EditorFileSystemDirectory structure above during the scan.

@reduz
Clean up EditorFileSystem script parsing
5bdc0d9 
* Optimize only update modified/added/removed files.
* Clean up documentation parsing.
@reduz reduz force-pushed the fixup-editor-file-system-script-parsing branch from a2631d9 to 5bdc0d9 Compare January 18, 2023 19:57
@reduz reduz requested a review from a team as a code owner January 18, 2023 19:57
@adamscott
Copy link
Member

Looks good to me!

@akien-mga akien-mga merged commit 4679f87 into godotengine:master Jan 19, 2023
@akien-mga
Copy link
Member

Thanks!

reduz added a commit to reduz/godot that referenced this pull request Jan 19, 2023
@reduz
Further fixes to global script class parsing
c0a81b1 
Bugs were introduced on first parse by godotengine#71628

This should fix everything remaining. No errors of any type were observed.
@reduz reduz mentioned this pull request Jan 19, 2023
Merged
@adamscott adamscott mentioned this pull request Jan 22, 2023
Closed
@akien-mga akien-mga mentioned this pull request Jan 22, 2023
Closed
Streq pushed a commit to Streq/godot that referenced this pull request Feb 9, 2023
@reduz @Streq
Further fixes to global script class parsing
8ef6fc1 
Bugs were introduced on first parse by godotengine#71628

This should fix everything remaining. No errors of any type were observed.
@and-rad and-rad mentioned this pull request Mar 13, 2023
Open
@and-rad and-rad mentioned this pull request Apr 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement performance topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@reduz @adamscott @akien-mga @KoBeWi