Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert SceneTree::GroupCallFlags enum to BitField flags #72260

Closed
wants to merge 1 commit into from
Closed

Convert SceneTree::GroupCallFlags enum to BitField flags #72260

wants to merge 1 commit into from

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jan 28, 2023

No description provided.

@Chaosus Chaosus requested review from a team as code owners January 28, 2023 16:00
@Chaosus Chaosus added this to the 4.0 milestone Jan 28, 2023
@Chaosus Chaosus force-pushed the scene_tree_group_call_flags branch 2 times, most recently from 427e865 to c0a8194 Compare January 28, 2023 16:17
@Chaosus
Copy link
Member Author

Chaosus commented Jan 28, 2023 •
edited
Loading

Documentation seems to cannot handle the flags through bind_vararg_method so call_group_flags does not show that parameter as flags.

@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 10, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
@Chaosus Chaosus force-pushed the scene_tree_group_call_flags branch 2 times, most recently from 80ddb27 to ff2211f Compare October 13, 2023 12:08
@akien-mga akien-mga requested a review from dalexeev October 13, 2023 12:16
@akien-mga
Copy link
Member

Seems good to me, I just wonder if this has implications for @godotengine/gdextension or @godotengine/dotnet compatibility?

dalexeev
dalexeev reviewed Oct 13, 2023
View reviewed changes
scene/main/scene_tree.h Outdated Show resolved Hide resolved
scene/main/scene_tree.cpp Outdated Show resolved Hide resolved
@dalexeev
Copy link
Member

I just wonder if this has implications for godotengine/gdextension or godotengine/dotnet compatibility?

CI reported an error about missing compatibility methods for GDExtension. I'm not sure about C#, but there is mono/glue/GodotSharp/GodotSharp/Compat.cs.

@Chaosus Chaosus force-pushed the scene_tree_group_call_flags branch from ff2211f to 081dfb7 Compare October 13, 2023 12:49
@Chaosus
Copy link
Member Author

Chaosus commented Oct 13, 2023

@akien-mga I don't remember how to fix the gdextension part now, if you can help me with this thing I would be appreciated.

@dalexeev
Copy link
Member

I don't remember how to fix the gdextension part now, if you can help me with this thing I would be appreciated.

See #80410 for example. You need to add .compat.inc file, include it in .cpp, add some code to .h, and add Validate extension JSON to 4.1-stable.expected file.

@raulsntos
Copy link
Member

If a compat method is added to ClassDB, it should be automatically generated for C# too. So there's no need to edit Compat.cs.

@Chaosus
Copy link
Member Author

Chaosus commented Oct 16, 2023

I didn't managed to undestand what should I add to make it work, I better close it for now...

@Chaosus Chaosus closed this Oct 16, 2023
@Chaosus Chaosus deleted the scene_tree_group_call_flags branch October 16, 2023 08:32
@Chaosus Chaosus removed this from the 4.2 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev dalexeev left review comments

Assignees
No one assigned
Labels
archived enhancement topic:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Chaosus @akien-mga @dalexeev @raulsntos @YuriSizov