Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the jumping to function definition using 'Ctrl+LMB' (reverted) #72789

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Fixed the jumping to function definition using 'Ctrl+LMB' (reverted) #72789

merged 1 commit into from
Feb 7, 2023

Conversation

Vilcrow
Copy link
Contributor

@Vilcrow Vilcrow commented Feb 6, 2023

Fixes #72353.

@Vilcrow Vilcrow requested a review from a team as a code owner February 6, 2023 11:26
@akien-mga akien-mga added this to the 4.0 milestone Feb 6, 2023
@Vilcrow Vilcrow force-pushed the fix-jump-to-definition branch from 70969f1 to 7eb6367 Compare February 7, 2023 02:31
@akien-mga akien-mga merged commit 3f95b39 into godotengine:master Feb 7, 2023
@akien-mga
Copy link
Member

Thanks!

@Vilcrow Vilcrow deleted the fix-jump-to-definition branch February 7, 2023 22:43
@akien-mga akien-mga mentioned this pull request Feb 12, 2023
Closed
This was referenced Feb 13, 2023
Merged
Closed
@akien-mga akien-mga changed the title Fixed the jumping to function definition using 'Ctrl+LMB'. Fixed the jumping to function definition using 'Ctrl+LMB' (reverted) Feb 13, 2023
@akien-mga
Copy link
Member

Reverted with d405392 to fix regressions (#73058, #73167).

We'll keep working on this to merge after the 4.0-stable release in #73196.

@Vilcrow Vilcrow mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnen vnen vnen approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:gdscript
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

self.function syntax won't trigger Ctirl+Click -> jump to definition.
3 participants
@Vilcrow @akien-mga @vnen