Fix byte packing (and buffer overrun) in godot_webxr_get_bounds_geometry() #73068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on PR #72938, I noticed this bug in
godot_webxr_get_bounds_geometry()
.It's incorrectly byte packing the data to pass it from Javascript to C++, and will actually overrun the buffer by 4 bytes!
Unlike the referenced issue, this one would be good to get in for 4.0.