Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Fix groups and categories been seen as members (reverted) #73870

Merged
merged 1 commit into from
Feb 24, 2023
Merged

GDScript: Fix groups and categories been seen as members (reverted) #73870

merged 1 commit into from
Feb 24, 2023

Conversation

vnen
Copy link
Member

@vnen vnen commented Feb 24, 2023

Fix #73843

@vnen vnen added this to the 4.0 milestone Feb 24, 2023
@vnen vnen requested a review from a team as a code owner February 24, 2023 13:04
@akien-mga akien-mga merged commit 7e00cc1 into godotengine:master Feb 24, 2023
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

akien-mga commented Feb 24, 2023 •
edited
Loading

Oops, I merged by mistake before CI passed, and obviously with a hardcoded Object ID in the test it didn't pass :})

Edit: Fixed by a6baebc.

akien-mga added a commit that referenced this pull request Feb 24, 2023
@akien-mga
Fixup GDScript test using non-deterministic ids
a6baebc 
Follow-up to #73870.
@vnen vnen deleted the gdscript-dont-reference-group-properties branch February 24, 2023 13:42
@YuriSizov YuriSizov changed the title GDScript: Fix groups and categories been seen as members GDScript: Fix groups and categories been seen as members (reverted) Feb 25, 2023
@YuriSizov YuriSizov mentioned this pull request Feb 25, 2023
Closed
@Malcolmnixon Malcolmnixon mentioned this pull request Feb 25, 2023
Closed
JeffVenancius pushed a commit to JeffVenancius/godot that referenced this pull request Mar 3, 2023
@akien-mga @JeffVenancius
Fixup GDScript test using non-deterministic ids
ca8fdb9 
Follow-up to godotengine#73870.
@dalexeev dalexeev mentioned this pull request Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Invalid call. Nonexistent function 'new' in base 'Nil'. if you use @export_group with same class name
2 participants
@vnen @akien-mga