Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restrictions to MultiplayerSynchronizer editor and documentation #74443

Merged
merged 1 commit into from
May 24, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Mar 5, 2023

Object based properties won't be synchronized properly, this restricts them being picked, and documents this limitation.

Also preventing and warning on RIDs as they won't work either, properties holding ObjectID or similar, mainly aiming to prevent errors that might not be obvious to users.

Note that this does not give any errors on running or prevent the creation of such property syncing, it continues to "fail" silently as before.

Fixes #74325

@AThousandShips
Copy link
Member Author

CC @Faless

Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had time to test this code, but the changes do make sense. cc @Faless

@mhilbrunner mhilbrunner requested a review from Faless May 6, 2023 13:30
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work 🏆

@Faless Faless merged commit b7032b5 into godotengine:master May 24, 2023
@Faless
Copy link
Collaborator

Faless commented May 24, 2023

Thanks!

@AThousandShips AThousandShips deleted the sync_restrictions branch May 24, 2023 14:09
@AThousandShips
Copy link
Member Author

great work

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiplayerSynchronizer doesn't update Texture property
5 participants