-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restrictions to MultiplayerSynchronizer editor and documentation #74443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CC @Faless |
AThousandShips
force-pushed
the
sync_restrictions
branch
from
March 6, 2023 11:20
3bd496a
to
94983de
Compare
AThousandShips
force-pushed
the
sync_restrictions
branch
from
May 4, 2023 16:24
94983de
to
c6ab3a8
Compare
mhilbrunner
approved these changes
May 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had time to test this code, but the changes do make sense. cc @Faless
AThousandShips
force-pushed
the
sync_restrictions
branch
from
May 24, 2023 07:37
c6ab3a8
to
f69fba0
Compare
Faless
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work 🏆
Thanks! |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object
based properties won't be synchronized properly, this restricts them being picked, and documents this limitation.Also preventing and warning on
RIDs
as they won't work either, properties holdingObjectID
or similar, mainly aiming to prevent errors that might not be obvious to users.Note that this does not give any errors on running or prevent the creation of such property syncing, it continues to "fail" silently as before.
Fixes #74325