Work around a race condition with ScriptServer during initialization #74501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #73793
Currently,
WorkerThreadPoolis initialized beforeScriptServer, so there's a race condition where worker threads call intoScriptServer::thread_enter()before languages are registered. SinceScriptServerisn't always initialized (for example, when Godot is run with--help), there's no synchronization point where threads can wait for languages to be registered before proceeding, so we just disable it for now.The proper fix is of course to rearrange
main()so that threads andWorkerThreadPoolare initialized last, which should probably wait until after #49362 (or possibly even be done there). This can be reverted afterwards.Needed for ThreadSanitizer #73777