Make main editor window border margin controllable by theme #74767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
enhancement
topic:editor
topic:gui
cherrypick:3.x
|
See also #40287. |
YuriSizov
reviewed
Mar 13, 2023
davthedev
force-pushed
the
main_margins_themeable
branch
from
bd04d34 to
8b1ff2e
Compare
|
While #40287 didn't get much approval, from what I can see this change looks like a good one and a step in the right direction towards better theming of the editor, other than being expected behavior (see: godotengine/godot-proposals#6482 (comment)) It also looks fairly trivial. What's stopping this one (although, tbf, this is "relatively" young)? |
YuriSizov
removed
the
cherrypick:3.x
davthedev
force-pushed
the
main_margins_themeable
branch
from
8b1ff2e to
a8fc343
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main window border margin and separation between top bar and the rest of the editor are currently hardcoded to 8px in the source code.
Proposal: godotengine/godot-proposals#6482
This change moves those values to editor theme constants, so that they can be controlled by a custom theme.
The editor theme generation is updated in consequence with the same values by default.
Can be backported to 3.x