Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coloring for completion of vector components #74809

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Mar 12, 2023

This is an editor enhancement, which adds a theme colour override for completion items of vector components.

GDScript editor:
image

Shader editor:
image

@Chaosus Chaosus requested review from a team as code owners March 12, 2023 07:38
@Chaosus Chaosus added this to the 4.1 milestone Mar 12, 2023
@Chaosus Chaosus force-pushed the completion_color_xyzw branch 4 times, most recently from 24f9812 to 1d8f952 Compare March 12, 2023 10:29
@Riteo
Copy link
Contributor

Riteo commented Mar 28, 2023

OMG that's so pretty!

I wonder though, does this happen for other completions? Could it happen for other completions?

Also, I wonder if this fancy feature could be toggled off, just in case it might give problems for some people, which is what I fear it might do for e.g. accessibility reasons, dunno.

@Chaosus
Copy link
Member Author

Chaosus commented Apr 4, 2023

I wonder though, does this happen for other completions? Could it happen for other completions?

I think yes, but for which? What do you suggest? (This could be added in the future PR).

Also, I wonder if this fancy feature could be toggled off, just in case it might give problems for some people, which is what I fear it might do for e.g. accessibility reasons, dunno.

Thanks for remind this, I've added the flag to disable this feature:

image

@Chaosus Chaosus force-pushed the completion_color_xyzw branch 2 times, most recently from 936617a to c327b3f Compare April 4, 2023 05:13
@Chaosus Chaosus requested a review from a team as a code owner April 4, 2023 05:13
@Riteo
Copy link
Contributor

Riteo commented Apr 5, 2023

@Chaosus

I think yes, but for which? What do you suggest? (This could be added in the future PR).

Not sure but I guess that we could see that later as this would already probably cover most of the usecase of this feature.

@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
@akien-mga akien-mga requested review from Calinou and YuriSizov August 29, 2023 07:11
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected:

Screenshot_20230829_100027

image

Tested types (excluding compound types that include Vectors as part of their properties): Vector2, Vector2i, Vector3, Vector3i, Vector4, Vector4i, Basis

Note that a script property (or subclass property) called x, y, z or w will not be colored.

@Chaosus Chaosus force-pushed the completion_color_xyzw branch 3 times, most recently from 0895f41 to 6f524ed Compare August 30, 2023 17:05
@Chaosus Chaosus force-pushed the completion_color_xyzw branch from 6f524ed to a39f65b Compare August 30, 2023 17:57
@Chaosus Chaosus force-pushed the completion_color_xyzw branch from a39f65b to 3580237 Compare August 30, 2023 18:13
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit dd4fae6 into godotengine:master Sep 4, 2023
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the completion_color_xyzw branch September 4, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants