Add option to toggle visibility of Position gizmos in 2D editor, organize existing options

[J-N-Witch]

This change lets you hide Position gizmos on 2D nodes
allowing you to make clean screenshots in the editor without crosses everywhere, among other things.

In order to avoid clutter in 2D > View menu, "Show Group And Lock Icons" and "Show Gizmos"
were moved to "Gizmos" submenu along with the newly added option.

Before:

After:

menu.mp4

Related proposal: godotengine/godot-proposals#6344

show_edit_locks (which actually referred to showing locks and groups)
was renamed to show_lock_gizmos to be consistent with the existing show_transformation_gizmos;
and was decoupled from group gizmos.

I would like have this in 3.x as well.

[Drkie]

@YuriSizov any reason this got moved from 4.1? It doesn't seem like it will make it to 4.2 either.

[YuriSizov]

@Drkie Nobody reviewed it thus far, so it can't be considered for the next release. Indeed, it won't make the cut for 4.2 either at this point, because we're entering feature freeze. But thanks for bumping it, that should put more eyes on it 👍

[KoBeWi]

IMO a single-element separated section is a bit awkward:

Maybe the Gizmos could be part of the first section. You could move the Grid to the bottom of the section, so two menus would be next to each other. Also Clear Guides is at odd spot, it could be near the checkboxes too (though not sure).

[J-N-Witch]

IMO a single-element separated section is a bit awkward

This is exactly how the existing Gizmos menu in 3D looks like.

The pattern is also repeated in many other places. See "Scene > Export As...", "Project > Version Control" etc.

Anyways, does this look better or should we keep the current layout?

Also Clear Guides is at odd spot, it could be near the checkboxes too (though not sure).

I think messing with Clear Guides is out of scope for this change.

[J-N-Witch]

Any thoughts on my comment above @AThousandShips @KoBeWi ?

I have rebased the change on the latest master and implemented your suggestions, let me know if there's anything else I can do.

[AThousandShips]

Haven't tested but code looks good

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉