Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Bump the target SDK version to 33 (Android 13) #75205

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Mar 22, 2023

@m4gr3d m4gr3d added this to the 3.6 milestone Mar 22, 2023
@m4gr3d m4gr3d requested a review from a team as a code owner March 22, 2023 02:18
@cengiz-pz
Copy link

@m4gr3d, @akien-mga, Android SDK version 33 introduces a new POST_NOTIFICATIONS permission. I haven't seen anything related to this permission in the commit attached to this issue. Has this been addressed elsewhere? Even though the permission can be added manually, it would be nice to have it included in Godot's list of predefined permissions.

More info: https://developer.android.com/develop/ui/views/notifications/notification-permission

@SnailRabbids
Copy link

SnailRabbids commented Mar 22, 2023

@m4gr3d
Hi, I'm a customer and using godot for my android app. When do you think you can update godot to be compatible with Android 13 (sdk 33)? Can I change the SDK version manually (I'm currently using godot 3.5.1) or do I have to wait for a new version (3.6-stable?) and then re-build/upload my app to Google Play?

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Mar 26, 2023

@m4gr3d Hi, I'm a customer and using godot for my android app. When do you think you can update godot to be compatible with Android 13 (sdk 33)? Can I change the SDK version manually (I'm currently using godot 3.5.1) or do I have to wait for a new version (3.6-stable?) and then re-build/upload my app to Google Play?

@SnailRabbids If you're using Godot 3.5.1, you can change the target SDK version manually in the Android export window under the Custom Build section.

Screenshot 2023-03-26 at 9 56 37 AM

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Mar 26, 2023

@m4gr3d, @akien-mga, Android SDK version 33 introduces a new POST_NOTIFICATIONS permission. I haven't seen anything related to this permission in the commit attached to this issue. Has this been addressed elsewhere? Even though the permission can be added manually, it would be nice to have it included in Godot's list of predefined permissions.

More info: https://developer.android.com/develop/ui/views/notifications/notification-permission

@cengiz-pz The permission will be added in a follow-up PR.
This allows us to isolate build specific changes in case they introduce regressions.

@akien-mga akien-mga added cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Mar 29, 2023
@cengiz-pz
Copy link

Android SDK version 33 introduces a new POST_NOTIFICATIONS permission. I haven't seen anything related to this permission in the commit attached to this issue. Has this been addressed elsewhere? Even though the permission can be added manually, it would be nice to have it included in Godot's list of predefined permissions.

More info: https://developer.android.com/develop/ui/views/notifications/notification-permission

@m4gr3d, I have created issue #75673 to track this

@akien-mga akien-mga merged commit 2c2ae75 into godotengine:3.x Apr 11, 2023
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
@djrain
Copy link

djrain commented Aug 28, 2023

If you're using Godot 3.5.1, you can change the target SDK version manually in the Android export window under the Custom Build section.

To confirm, it's fine to just do this and no other changes are needed? Since it looks like 3.5.3 will not release in time.

@NianoTT
Copy link

NianoTT commented Aug 29, 2023

If you're using Godot 3.5.1, you can change the target SDK version manually in the Android export window under the Custom Build section.

To confirm, it's fine to just do this and no other changes are needed? Since it looks like 3.5.3 will not release in time.

Just check if your app is affected by any of the behaviour changes in 33:
https://developer.android.com/about/versions/13/behavior-changes-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants