Fix PackedScenes created with PackedScene.pack() have their exported nodes become null #75429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah KoBeWi recently poked at this code, but looking at the blame, Juan wrote the custom condition and KoBeWi seems confused about it. Maybe Juan should be the one to take a look? |
MewPurPur
force-pushed
the
Literally-cant-have-a-functioning-level-editor-because-of-this-please-helppp
branch
from
a605d50 to
40407b4
Compare
…nodes become null
MewPurPur
force-pushed
the
Literally-cant-have-a-functioning-level-editor-because-of-this-please-helppp
branch
from
40407b4 to
6c6c130
Compare
KoBeWi
approved these changes
Apr 24, 2023
|
Thanks! |
MewPurPur
deleted the
Literally-cant-have-a-functioning-level-editor-because-of-this-please-helppp
branch
|
Can't make a clean cherry-pick of this PR because it changes code affected by #73256. So we'll have to postpone picking it until the other one is picked. |
|
Yeah I think if we want #73256 in 4.0.x eventually, it would likely require a dedicated PR with all the relevant cherry-picks. There have been a lot of intertwined changes to PackedScene like this one. |
|
Regarding the cherry-pick, see my comment here: #76378 (comment). We recommend updating to 4.1 if this issue greatly affects you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73315 as per KoBeWi's comment. I have no idea what I'm doing here, so I hope this is the exact proper solution, I'll not be able to make major modifications if request arises.
Tested it on my game and I didn't encounter any regressions. But tbh I don't exactly know what kinds of regressions I should be looking for...