[3.x] Make MessageQueue growable #75527
Conversation
* Uses simple vector resizing (po2) * Uses pair of read and write buffers
|
We discussed the message queue PRs today and @reduz is fine with this one for 3.x, I've tested it quite a bit now, but if e.g. @KoBeWi or @RandomShaper or @akien-mga want to give a second look that would be welcome, so we can get approved and in for 3.6. 👍 |
| @@ -1190,7 +1190,7 @@ | |||
| </member> | |||
| <member name="memory/limits/command_queue/multithreading_queue_size_kb" type="int" setter="" getter="" default="256"> | |||
| </member> | |||
| <member name="memory/limits/message_queue/max_size_kb" type="int" setter="" getter="" default="4096"> | |||
| <member name="memory/limits/message_queue/max_size_mb" type="int" setter="" getter="" default="32"> | |||
There was a problem hiding this comment.
Should we keep this in kB so we don't break compat on the property name?
There was a problem hiding this comment.
I don't think breaking compatibility here matters all that much, as the new version grows / shrinks on demand, so the max value can be higher. Any old values stored will be overly low for new version, so in a way it makes more sense to change this name.
The default of 32 megs I think came from reduz PR, but it seems reasonable even on mobile. In most situations it will only use a few Kb, and peak only during e.g. loading. It's possible we could use a slightly smaller peak for mobile, but this kind of thing should become obvious with testing.
|
Thanks! |
3.x version of #65740
See that PR for more details.