Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moving position indicator out of bounds in FileAccessMemory #75641

Merged

Conversation

Listwon
Copy link
Contributor

@Listwon Listwon commented Apr 4, 2023

Position indicator was incremented by p_length in get_buffer() and store_buffer() even if it meant exceeding buffer length.

@Listwon Listwon requested a review from a team as a code owner April 4, 2023 08:15
@akien-mga akien-mga added bug topic:core cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.0 labels Apr 4, 2023
@akien-mga akien-mga added this to the 4.1 milestone Apr 5, 2023
@akien-mga akien-mga merged commit d985d55 into godotengine:master Apr 5, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

@akien-mga
Copy link
Member

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 28, 2023
@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants