Remove double vertex addition when using precision=double for multimesh rendering #75788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, this is causing some issues with MultiMeshInstanced3D - this is not the right solution. Will continue to tweak it. |
|
@clayjohn This may be beyond me to fix. Anything you see at a glance that could be causing the double positioning? |
|
Superseded by #76003. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75549
When in a multimesh pass on Vulkan and precision=double, the model_origin was being added to the vertex twice.
Applies to GPUParticles3D as well as MultiMeshInstance3D.
(Second animation was also using the billboard fix from #75462 but is not required for this fix to work).