Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTTPClient _request using wrong size #75867

Merged
merged 1 commit into from
May 14, 2023
Merged

Fix HTTPClient _request using wrong size #75867

merged 1 commit into from
May 14, 2023

Conversation

tefusion
Copy link
Contributor

@tefusion tefusion commented Apr 9, 2023

Fixes #75866

@tefusion tefusion requested a review from a team as a code owner April 9, 2023 19:03
RedworkDE
RedworkDE reviewed Apr 9, 2023
View reviewed changes
core/io/http_client.cpp Outdated Show resolved Hide resolved
@YuriSizov YuriSizov added this to the 4.1 milestone Apr 10, 2023
@tefusion
Fix HTTPClient _request using wrong size
1514376 
This only affects HttpClient in GDScript.
@tefusion tefusion force-pushed the fix_http_client_unicode_request branch from 8c4b145 to 1514376 Compare April 10, 2023 09:46
Faless
Faless approved these changes May 14, 2023
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Faless Faless merged commit fb10f45 into godotengine:master May 14, 2023
@Faless
Copy link
Collaborator

Faless commented May 14, 2023

Thanks!

@tefusion tefusion deleted the fix_http_client_unicode_request branch May 14, 2023 14:52
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov left review comments

@RedworkDE RedworkDE RedworkDE approved these changes

@Faless Faless Faless approved these changes

Assignees
No one assigned
Labels
bug topic:network
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

HTTPClient doesn't work with a body containing special characters
5 participants
@tefusion @Faless @YuriSizov @RedworkDE @timothyqiu