Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp normal when calculating 2D lighting to avoid artifacts #76240

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Apr 19, 2023

Fixes: #76233

This is the same fix that was applied to 3.3 in #44293. The Godot 4 2D rendering must have diverged before #44293 was made.

Before:
Screenshot from 2023-04-18 17-24-35

After:
Screenshot from 2023-04-18 17-24-16

@clayjohn clayjohn added this to the 4.1 milestone Apr 19, 2023
@clayjohn clayjohn requested a review from lawnjelly April 19, 2023 00:27
@clayjohn clayjohn requested a review from a team as a code owner April 19, 2023 00:27
@clayjohn
Copy link
Member Author

clayjohn commented Apr 19, 2023

I'm still looking into this by the way. The discussion in #44285 never fully settled. It seems like this change may only be a partial fix for the worst of it

Nevermind, this should be good to go

@akien-mga akien-mga merged commit 27253f3 into godotengine:master Apr 19, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird Lighting and Artifacts with Normal Maps under Godot 4
2 participants