Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option for ButtonGroups to be unpressed #76279

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Add an option for ButtonGroups to be unpressed #76279

merged 1 commit into from
Apr 24, 2023

Conversation

TheSecondReal0
Copy link
Contributor

@TheSecondReal0 TheSecondReal0 commented Apr 20, 2023 •
edited by KoBeWi
Loading

@TheSecondReal0 TheSecondReal0 requested a review from a team as a code owner April 20, 2023 03:29
@TheSecondReal0 TheSecondReal0 mentioned this pull request Apr 20, 2023
Closed
@TheSecondReal0 TheSecondReal0 force-pushed the buttongroup-unpress branch 3 times, most recently from 77c787d to 9ec7342 Compare April 20, 2023 05:44
@TheSecondReal0 TheSecondReal0 requested a review from a team as a code owner April 20, 2023 05:44
@KoBeWi KoBeWi added this to the 4.x milestone Apr 20, 2023
KoBeWi
KoBeWi reviewed Apr 20, 2023
View reviewed changes
scene/gui/base_button.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Apr 20, 2023
View reviewed changes
doc/classes/ButtonGroup.xml Outdated Show resolved Hide resolved
Chaosus
Chaosus reviewed Apr 20, 2023
View reviewed changes
scene/gui/base_button.cpp Outdated Show resolved Hide resolved
Chaosus
Chaosus reviewed Apr 20, 2023
View reviewed changes
scene/gui/base_button.h Outdated Show resolved Hide resolved
Chaosus
Chaosus reviewed Apr 20, 2023
View reviewed changes
scene/gui/base_button.cpp Outdated Show resolved Hide resolved
Chaosus
Chaosus reviewed Apr 20, 2023
View reviewed changes
scene/gui/base_button.cpp Outdated Show resolved Hide resolved
@kleonc
Copy link
Member

kleonc commented Apr 20, 2023

@TheSecondReal0 A single commit is preferred, please squash the commits (see the docs for how to rebase).

kleonc
kleonc reviewed Apr 20, 2023
View reviewed changes
scene/gui/base_button.cpp Outdated Show resolved Hide resolved
@TheSecondReal0 @KoBeWi
@Chaosus @kleonc
Add option for ButtonGroups to be unpressed
d829b43 
Add an option for ButtonGroups to be unpressed

Apply suggestions from code review

Co-Authored-By: Tomek <kobewi4e@gmail.com>
Co-Authored-By: Yuri Rubinsky <chaosus89@gmail.com>
Co-Authored-By: kleonc <9283098+kleonc@users.noreply.github.com>
akien-mga
akien-mga approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.1 Apr 24, 2023
@akien-mga akien-mga merged commit 1f76ad0 into godotengine:master Apr 24, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chaosus Chaosus Chaosus left review comments

@kleonc kleonc kleonc left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement feature proposal topic:gui
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Allow unpressing all buttons in a ButtonGroup
5 participants
@TheSecondReal0 @kleonc @akien-mga @KoBeWi @Chaosus