Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade android gradle plugin to version 7.2.1. #76325

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Apr 21, 2023

Version 7.3.0 changes the build layout which causes updates to the generated shared libraries to not be picked up.

3.x version

Version 7.3.0 changes the build layout which causes updates to the generated shared libraries to not be picked up.
@akien-mga
Copy link
Member

I feel like AGP breaks compat every minor version, is that expected?

How could we better test for this to prevent future breakage? I remember we also had issues upgrading to 7.2.1 for a long time.

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This partially reverts #75203
Is #74646 affected?

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 21, 2023

This partially reverts #75203 Is #74646 affected?

@KoBeWi No it's not affected; the gradle version remains the same, it's the Android gradle plugin version that is updated.

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 21, 2023

I feel like AGP breaks compat every minor version, is that expected?

How could we better test for this to prevent future breakage? I remember we also had issues upgrading to 7.2.1 for a long time.

Given our tooling doesn't fully match with their expected tooling (i.e: scons instead of cmake), yes there are some expectations of minor breakages when they change their underlying infra.

@akien-mga akien-mga merged commit 220d44e into godotengine:master Apr 22, 2023
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the downgrade_agp_main branch April 23, 2023 03:09
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants