Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid accessing the theme too early in EditorRunBar #76513

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

YuriSizov
Copy link
Contributor

@YuriSizov YuriSizov commented Apr 27, 2023

Fixes #76509.

I missed it initially because it happens before the editor output can display those errors, so you can only see it in the terminal during the startup. Perhaps we could somehow store those messages, and then print them once the editor output is ready?

@akien-mga akien-mga merged commit b81387d into godotengine:master Apr 27, 2023
@akien-mga
Copy link
Member

Thanks!

@Araraura
Copy link
Contributor

I'm still experiencing #76509 when opening any project in 4.1.1-stable. Not sure what might be causing this, I'm not using any undocked windows either. The line where the warning is outputted is different from the original issue:

scene/gui/control.cpp:2522 - Attempting to access theme items too early; prefer NOTIFICATION_POSTINITIALIZE and NOTIFICATION_THEME_CHANGED

And here's a project it's occurring for me on
Kenney2023Game.zip

@YuriSizov
Copy link
Contributor Author

@Araraura Please open an issue. The error is generic and is not related to a specific control, each case needs to be investigated individually. When you create an issue, please specify what steps do you take for the error to appear. For example, which parts of the editor do you interact with and how right before the message appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants