Preserve scene unique names when saving branch as scene. #76609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you link the issue it fixes? |
|
Can you make an issue if it doesn't exist? |
|
Not sure if opening a new issue in necessary. Basically:
|
kleonc
approved these changes
Apr 30, 2023
|
Will need the issue to close before merging. |
|
Added an issue. Is an issue always needed for usability improvements? |
|
tbh an issue wasn't needed in this case. The PR had all necessary details. |
No, it's not necessarily needed, but I think it's preferred, especially if there's no urgency to the PR. It helps tracking what has been done, what issues has been fixed. |
|
Will keep this in mind for the future. |
KoBeWi
approved these changes
Apr 30, 2023
|
Looks great! Thanks! |
|
Cherry-picked for 4.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #76614
When saving a branch as scene it did loose its unique scene name within the original scene. Now it is preserved so that scripts in the original scene don't break when splitting a scene up.