-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useful functions to FilterEdit
in AnimationBlendTreeEditor
#76654
Add useful functions to FilterEdit
in AnimationBlendTreeEditor
#76654
Conversation
FilterEdit
in AnimationBlendTreeEditor
FilterEdit
in AnimationBlendTreeEditor
e7723e9
to
e133f2e
Compare
e133f2e
to
f3f2d3a
Compare
As this is editor related, maybe the editor team should take a look at this, how to implement this PR editor-wide. |
I don't really know the workflow this touches on, so I can't say if this is the best way to do it or not. If you want to give me a few examples of how it would be used by users, I can offer an opinion. Otherwise, we can just roll with it. |
The most common case is to select only the upper or lower body. For that currently, we needs to select all the bones, which is tedious. Also, due to the deep nesting, the ability to select children of the selected objects in the tree would make sense IMO. Ideally, I would like to add multiple selections, but it is a bit complicated and will not be added in this PR. |
Trees have a method to propagate checks (both upwards and downwards), so this can be done without extra controls, if it would be acceptable to always select all child bones when a parent bone is checked. |
@YuriSizov There is no such functionality in the current FillterEdit, so I assume it would need to be added. Do you mean to use call_recursive()? |
@TokageItLab I don't know what If this behavior makes sense in your workflow, you should use it. |
Oh I see, I think FillSelectedChildren can be replaced with a bool option that determines if it uses propagate_check() or not, so I'll look at that later. |
I'll convert it into draft for now. Feel free to undraft it once it's ready to be reviewed again :) |
f3f2d3a
to
afe2593
Compare
@YuriSizov I found that propagate_check is unusable, FilterEdit is just using Tree for display purposes. Also Bone does not treat the children as a group, they are parent-child relationships, and since each is independent and has only 1 column, so propagate_check will not work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While there's likely ways the usability of this can be improved further (I feel like it could benefit from keyboard shortcuts and maybe a right-click menu), this is still a massive usability improvement over the original filter track editor so I approve merging this.
Thanks! |
Editing filters in
AnimationBlendTreeEditor
was a pain since we had to make individual selections and switches for every bone when editing filters. This PR adds 3 useful options for editing filters.