-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backward_undo_ops
as option for action
#76688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajreckof
changed the title
add backward_undo_ops as property for action
add backward_undo_ops as option for action
May 3, 2023
fire
changed the title
add backward_undo_ops as option for action
Add backward_undo_ops as option for action
May 3, 2023
KoBeWi
reviewed
Jun 2, 2023
KoBeWi
reviewed
Jun 2, 2023
KoBeWi
reviewed
Jun 2, 2023
KoBeWi
reviewed
Jun 2, 2023
ajreckof
force-pushed
the
backward_undo
branch
2 times, most recently
from
June 3, 2023 01:46
43d6ba1
to
54443fe
Compare
KoBeWi
reviewed
Jun 10, 2023
KoBeWi
reviewed
Jun 10, 2023
KoBeWi
reviewed
Jun 10, 2023
KoBeWi
approved these changes
Jun 10, 2023
Needs a rebase to fix CI, the doc checks were broken temporarily yesterday by another PR. |
Done. I wouldn't mind someone checking the C# syntax as I don't use C# so I'm not sure what I wrote in the doc is correct. |
KoBeWi
reviewed
Jun 13, 2023
akien-mga
changed the title
Add backward_undo_ops as option for action
Add Jun 14, 2023
backward_undo_ops
as option for action
This is technically a new feature, but it's needed for a bugfix (#76376) so we accept to merge it for 4.1 despite the feature freeze. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60836
This fix the case were people want undos to be ordered backward. This is especially useful when using loops or delegating the undo/redos to another function.