Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backward_undo_ops as option for action #76688

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

ajreckof
Copy link
Member

@ajreckof ajreckof commented May 3, 2023

Fixes #60836

This fix the case were people want undos to be ordered backward. This is especially useful when using loops or delegating the undo/redos to another function.

@ajreckof ajreckof requested review from a team as code owners May 3, 2023 02:40
@ajreckof ajreckof changed the title add backward_undo_ops as property for action add backward_undo_ops as option for action May 3, 2023
@fire fire changed the title add backward_undo_ops as option for action Add backward_undo_ops as option for action May 3, 2023
@Chaosus Chaosus added this to the 4.x milestone May 8, 2023
core/object/undo_redo.cpp Outdated Show resolved Hide resolved
core/object/undo_redo.h Outdated Show resolved Hide resolved
@ajreckof ajreckof force-pushed the backward_undo branch 2 times, most recently from 43d6ba1 to 54443fe Compare June 3, 2023 01:46
@akien-mga akien-mga requested a review from KoBeWi June 10, 2023 11:00
doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

Needs a rebase to fix CI, the doc checks were broken temporarily yesterday by another PR.

@ajreckof
Copy link
Member Author

ajreckof commented Jun 13, 2023

Done. I wouldn't mind someone checking the C# syntax as I don't use C# so I'm not sure what I wrote in the doc is correct.

doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
@akien-mga akien-mga changed the title Add backward_undo_ops as option for action Add backward_undo_ops as option for action Jun 14, 2023
@akien-mga
Copy link
Member

akien-mga commented Jun 14, 2023

This is technically a new feature, but it's needed for a bugfix (#76376) so we accept to merge it for 4.1 despite the feature freeze.

@akien-mga akien-mga merged commit 50b3b17 into godotengine:master Jun 14, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UndoRedo doesn't undo in the reverse order
5 participants