Support long path in file access on Windows #76739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed windows file access file to check for path length and use the \\?\ long format when needed
spanzeri
force-pushed
the
fix-long-path-windows
branch
from
7bb5925
to
59f04e1
Compare
|
Made the same changes to dir_access and tested more thoroughly with totally sensible file names in the editor: |
RandomShaper
approved these changes
May 5, 2023
bruvzg
approved these changes
May 5, 2023
mhilbrunner
approved these changes
May 5, 2023
|
Thanks! Merged. |
akien-mga
changed the title
|
Cherry-picked for 4.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for some of the issues with long paths on windows (in particular with shader cache).
Fixes: #73583
Should fix most of the cases for this: #52799
Note that dir_access already uses the \?\ format for long paths.
My understanding from the microsoft docs is that unicode version of the file functions all support this format.
However, I haven't tested it on older windows versions and there might be some good reasons to not do this