Fix shader editor crash #77467
Merged
Fix shader editor crash #77467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QbieShay
reviewed
May 25, 2023
bitsawer
force-pushed
the
fix_shader_editor_crash
branch
from
0ebe508
to
993e671
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an unreported (?) crash when editing shaders and shader includes using the shader editor.
Seems like this small error was introduced by #72277. This PR adds a check to make sure the right type of resource is used, previously it would sometimes crash when handling a ShaderInclude.
Bugsquad edit: