Fix shader preprocessor cyclic include handling #77608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75813
Normally, shader include dependencies are calculated starting from the root shader, but when editing a shader include directly in the editor the depencencies are not always fully known until a full compile is done. This PR adds a success check to preprocessing step and only updates dependencies if the preprocessing worked. Now a proper cyclic dependency error message is shown and the engine doesn't crash.
While investigating this I also made a few more minor fixes: