Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated C# code example for class AnimationNodeOneShot #77698

Merged
merged 1 commit into from
May 31, 2023
Merged

Fix outdated C# code example for class AnimationNodeOneShot #77698

merged 1 commit into from
May 31, 2023

Conversation

enxas
Copy link
Contributor

@enxas enxas commented May 31, 2023 •
edited
Loading

Updates C# code example for AnimationNodeOneShot. AnimationNodeOneShot.OneShotRequest enum needs to be cast to an int, because AnimationTree.Set() method second parameter requires Variant type.

@enxas enxas requested a review from a team as a code owner May 31, 2023 15:10
RedworkDE
RedworkDE requested changes May 31, 2023
View reviewed changes
Copy link
Member

@RedworkDE RedworkDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message and PR title could also be improved a bit by mentioning which example you fixed.

LGTM otherwise.

doc/classes/AnimationNodeOneShot.xml Outdated Show resolved Hide resolved
@enxas enxas force-pushed the fix-outdated-csharp branch from 2317970 to b463518 Compare May 31, 2023 15:57
@enxas enxas changed the title Fix outdated C# example code Fix outdated C# code example for class AnimationNodeOneShot May 31, 2023
@enxas enxas force-pushed the fix-outdated-csharp branch from b463518 to 5142b5d Compare May 31, 2023 16:26
@enxas enxas requested a review from RedworkDE May 31, 2023 16:28
@akien-mga akien-mga added this to the 4.1 milestone May 31, 2023
@akien-mga akien-mga merged commit 5c2295f into godotengine:master May 31, 2023
@akien-mga
Copy link
Member

Thanks!

@enxas enxas deleted the fix-outdated-csharp branch June 3, 2023 06:48
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedworkDE RedworkDE RedworkDE approved these changes

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
bug documentation topic:dotnet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@enxas @akien-mga @YuriSizov @raulsntos @RedworkDE