-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform update_mouse_cursor_state at most once per frame. #77781
base: master
Are you sure you want to change the base?
Perform update_mouse_cursor_state at most once per frame. #77781
Conversation
This enables processing of all Window nodes, which is a bit wasteful. |
I was afraid of that and am open to other suggestions.
|
I mean to use the same approach as that method, not the method itself.
|
8360370
to
774f563
Compare
Indeed I prefer this approach much more. Thanks for pointing me in the direction of call_deferred. |
Set a flag to perform the update once after input event processing. Add a color picker unit-test for the related issue.
774f563
to
19c62f7
Compare
While I prefer the second solution, I was unable to implement it in a way, that could be merged in a timely manner. The problem was the interaction of So I have reverted this PR to its previous state which enables processing on |
For lesser performance impact, you could enable process when the update is pending and disable it after update. |
Right, I am not going to use processing, but the flag + deferred call method. However this will have to wait until I have rewritten But since the referenced bug-report has been solved in a different way, it is fine for me, if this PR take more time. |
Set a flag to perform the update after input event processing during NOTIFICATION_PROCESS.
fix no longer #77773 (was solved in a different way)