Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create a new scene when double-clicking empty space in scene tabs #77883

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 5, 2023

This behavior was often accidentally triggered when using the scroll tab arrow buttons. Web browsers also lack equivalent behavior, which means that it's not an UX pattern that people often rely upon.

If you need to create a scene quickly from the scene tabs, a "+" button remains visible at the right of the last scene tab.

This behavior was often accidentally triggered when using the scroll
tab arrow buttons. Web browsers also lack equivalent behavior, which
means that it's not an UX pattern that people often rely upon.

If you need to create a scene quickly from the scene tabs, a "+"
button remains visible at the right of the last scene tab.
@akien-mga
Copy link
Member

Web browsers also lack equivalent behavior, which means that it's not an UX pattern that people often rely upon.

That's not fully accurate, Firefox behaves like this (at least on Linux).

I don't mind removing the feature (I don't use it).

@YuriSizov
Copy link
Contributor

That's not fully accurate, Firefox behaves like this (at least on Linux).

Indeed, this feature exists, or at least existed, in various browsers and tabbed applications. So I think that the feature is fine. But navigation arrows should consume clicks.

@Calinou
Copy link
Member Author

Calinou commented Jun 6, 2023

That's not fully accurate, Firefox behaves like this (at least on Linux).

I guess it depends on whether you have window borders shown, as doing this on my setup (which is also Linux) makes the window maximize itself (or restore itself is already maximized).

@kitbdev
Copy link
Contributor

kitbdev commented Oct 25, 2023

I think this was fixed in the TabBar itself by #79852

@Calinou
Copy link
Member Author

Calinou commented Oct 25, 2023

I think this was fixed in the TabBar itself by #79852

I can still reproduce this on 4.2.beta2:

simplescreenrecorder-2023-10-25_20.47.29.mp4

This occurs even if double-clicking far away from the last tab (as long as you click on the TabBar area).

@kitbdev
Copy link
Contributor

kitbdev commented Oct 25, 2023

Oh, I meant the linked issue #72313 was fixed, so it doesn't trigger when using the scroll buttons.
I don't know if we still want the double click to create new tabs feature to be removed or not, since that seemed like the main issue with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab bars scroll buttons, double-click creates new empty tab
4 participants