Fix uninitialized Y-sort modulate for CanvasItems #78134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #78035.
All MRPs I've tested in #77079 had top most Y-sorted item without actual visuals so haven't noticed that such root CanvasItem's
ysort_modulate
remains not initialized toColor(1, 1, 1, 1)
. And I must have not tested the simplest case of a single Y-sorted node. 🤦♂️Marking as
cherrypick:4.0
as #77079 is still labelled as such.