Add NavigationPolygon cell_size property
#78172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds NavigationPolygon cell_size property.
smix8
force-pushed
the
navpoly_cell_size_4.x
branch
from
9a5e778 to
9c8626b
Compare
akien-mga
approved these changes
Jun 13, 2023
akien-mga
changed the title
cell_size property
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NavigationPolygon
cell_sizeproperty, same as NavigationMesh already has.Theoretically this was always needed but 2D navigation did just assume a default 1.0 cell_size behind the scene. It never updated the cell_size correctly on the internal NavigationMesh from the default 0.25. There was no way for 2D users to change it other can getting the NavigationMesh manually and changing the cell_size.
Needed now because 2D runs into the cell_size validation for the navigation map on the NavigationServer added with #77714.
In case someone wonders why not just remove the check when it requires so much extra ... all the other prs that also require a cell_size property on the NavigationPolygon are not in yet and strictly speaking not able to change the cell_size was always a bug.