Add NavigationRegion rotation warning #78173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jun 13, 2023
Adds NavigationRegion rotation warning.
smix8
force-pushed
the
navregion_rot_warning_4.x
branch
from
5a0bae1
to
4d8553f
Compare
akien-mga
approved these changes
Jun 13, 2023
|
Thanks! |
|
This PR makes changes to a warning added in #77714. Should both PRs be cherry-picked for 4.0? |
|
@YuriSizov I think I did not add the cherry-pick for the other pr because I was unsure if the old version even had all the required changes so users would not suddenly receive this error msg without ways of actually doing all the required changes. E.g. I think in Godot 4.0 users are unable to change certain 2D properties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NavigationRegion rotation warning.
Fixes #78145.
NavigationMeshes / navigation region can not be rotated 90 degree or more away from the current navigation map
upvector without causing pathfinding and merge problems.