-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix batch rename for unique name and empty name #78292
Fix batch rename for unique name and empty name #78292
Conversation
ac3a396
to
9d1192f
Compare
9d1192f
to
b9af386
Compare
sorry I just found a rather important bug xd
b9af386
to
63119e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (rebased on top of master
cb73a6e), it works.
However, I can only confirm the first case (empty node name) is resolved, as I can't test the second issue. I never see the Batch Rename option in the context menu when selecting several nodes if both are scene-unique, and this also applies in master
.
Approving nonetheless, as this is an improvement over the existing situation.
Batch Rename does not appear if you select a parent and child node together. Likely a bug. |
Indeed See #76069 |
Besides a review from @KoBeWi this also needs a rebase. |
30420e9
to
e9d630d
Compare
So I rebased this. The conflicting fix was about making sure it wouldn't raise an error when renaming a node to the same name when it is an unique name in owner. I moved this fix to the new places from this PR |
da02b0b
to
98a0fe1
Compare
I think the added meta should be prefixed with "_" by convention. Otherwise, this seems to address @KoBeWi's concern, albeit in a rather awkward way. Can't we set the meta and then compose a line by checking for each possible key, instead of doing this nested |
editor/gui/scene_tree_editor.cpp
Outdated
|
||
// we previously made sure name is not the same as current name so that it wonn't complain about already used unique name when not changing name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// we previously made sure name is not the same as current name so that it wonn't complain about already used unique name when not changing name | |
// We previously made sure name is not the same as current name so that it won't complain about already used unique name when not changing name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poke @ajreckof, would be good to fix this before merging.
This convention is irrelevant for internal editor nodes. |
98a0fe1
to
4909396
Compare
Thanks! |
Fixes #78290
Fixes #78291