Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rpc calls with binds #78551

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Fix rpc calls with binds #78551

merged 1 commit into from
Jul 8, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Jun 22, 2023 •
edited
Loading

CallableCustomBind/Unbind did not pass on rpc calls, this makes them pass it on correctly, matching the behavior of a base Callable.

I put this under 4.x because not urgent but should be trivial to check for regressions so can be moved easily, but not a blocker IMO

@AThousandShips AThousandShips requested a review from a team as a code owner June 22, 2023 09:12
@AThousandShips AThousandShips added this to the 4.x milestone Jun 22, 2023
@akien-mga akien-mga requested a review from KoBeWi June 22, 2023 09:51
KoBeWi
KoBeWi approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of code duplication, but otherwise the implementation looks and works ok.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Jun 28, 2023
@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jun 28, 2023
@akien-mga akien-mga merged commit 0c1442f into godotengine:master Jul 8, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@AThousandShips AThousandShips deleted the call_rpc branch July 8, 2023 16:31
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:network
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Nonexistent function 'rpc' in base 'Callable'
4 participants
@AThousandShips @akien-mga @YuriSizov @KoBeWi