-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Add export_project_only
flag
#78641
iOS: Add export_project_only
flag
#78641
Conversation
4132ea2
to
fb0206f
Compare
a6b5b7d
to
1993b95
Compare
should be good for review if anyone is available :) |
okay, I think everything should be good now. I had to use a ternary for EditorProgress, as I couldn't hoist it, as it does not have a default constructor. Tested building on MacOS and running locally, everything worked okay. |
any recommendations for an ios reviewer? ideally hoping to get it in the next release :) |
It's already assign for review by the iOS team, but we're in complete feature freeze for 4.1 so reviewing features isn't the priority right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK.
This warning shown when exporting from non-macOS system probably should be suppressed if export_project_only
.
It still needs MacOS for step 2 though, so I think it's okay.? Perhaps adjusting the error might be the way? Or as both export types require MacOS to complete, should we just deny non-MacOS at the start rather than handling it later? |
As this does not impact android, should we remove the android reviewer? |
export_project_only
flag
Could you please squash your commits into one? Make sure that the final commit has a short but descriptive message (the title of this PR is a good option). See this documentation, if you need help with squashing. |
fb7aa93
to
c18c2d4
Compare
just squashed and pushed, let me know if it's all good! |
@phil-hudson Almost! You have an unrelated commit in there somehow. Also, we don't use the |
c18c2d4
to
7ecc5ce
Compare
7ecc5ce
to
97c2170
Compare
I force-pushed on your behalf to update the commit message. Edit: Actually, I also noticed that we were missing the necessary code to translate some of the messages, so I updated that as well. |
97c2170
to
076ef3b
Compare
Thanks! |
As per godotengine/godot-proposals#7147
This diff adds the following:
This is useful for situations where there are third party build tools doing additional configuration, e.g. Fastlane
I've tested locally and everything is working okay. My only additional thought was the feature might need better naming or description.
Thanks