Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Automatically generate version defines #78722

Merged
merged 1 commit into from
Jul 5, 2023
Merged

C#: Automatically generate version defines #78722

merged 1 commit into from
Jul 5, 2023

Conversation

RedworkDE
Copy link
Member

@RedworkDE RedworkDE commented Jun 26, 2023 •
edited
Loading

@RedworkDE RedworkDE requested a review from a team as a code owner June 26, 2023 18:52
@RedworkDE RedworkDE force-pushed the net-auto-version-defines branch 2 times, most recently from 668470a to c61b288 Compare June 26, 2023 18:56
@akien-mga akien-mga added this to the 4.2 milestone Jun 26, 2023
raulsntos
raulsntos approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

modules/mono/build_scripts/build_assemblies.py Outdated Show resolved Hide resolved
@raulsntos raulsntos added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jun 28, 2023
@RedworkDE RedworkDE force-pushed the net-auto-version-defines branch from c61b288 to fe7c27b Compare June 28, 2023 19:46
@RedworkDE RedworkDE mentioned this pull request Jun 28, 2023
Merged
@akien-mga akien-mga merged commit 8a847d8 into godotengine:master Jul 5, 2023
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.1.1.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 5, 2023
@RedworkDE RedworkDE deleted the net-auto-version-defines branch July 5, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
enhancement topic:buildsystem topic:dotnet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@RedworkDE @akien-mga @raulsntos