Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delay on tab resizing when (un)hovering tabs #78777

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

YeldhamDev
Copy link
Member

Currently, when hovering in and out of a tab with the mouse, the size of the tabs will take a second to properly update in case the hovered style is of a different size than the rest. This PR fixes that.

@YeldhamDev YeldhamDev added this to the 4.1 milestone Jun 28, 2023
@YeldhamDev YeldhamDev requested a review from a team as a code owner June 28, 2023 00:02
@YeldhamDev YeldhamDev modified the milestones: 4.1, 4.2 Jun 28, 2023
@YeldhamDev YeldhamDev added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jun 28, 2023
@KoBeWi
Copy link
Member

KoBeWi commented Jun 28, 2023

Any reproduction project?

@YeldhamDev
Copy link
Member Author

@KoBeWi Sorry for the late response. I don't think it needs a MRP, you just need to open the theme editor and apply a hovered tab style that is larger than the default one.

@YuriSizov YuriSizov merged commit 509645b into godotengine:master Jul 12, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@YeldhamDev YeldhamDev deleted the tab_hover_fix branch July 12, 2023 19:08
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants