-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons for 3D texture classes #78903
Add icons for 3D texture classes #78903
Conversation
I can't visually recognize CompressedTexture3D and NoiseTexture3D. |
Yep, Noise3d looks extremely close to generic Image3d... |
OK, let me revise |
I thought the NoiseTexture3D icon was showing something like fog. But it turned out to be 3D cubes when I open the SVG 🤣 I think using a flat image would be more easier to read. It does not have to be 3D since the image is like a sticker on a box. |
Squares should be good and familiar from the 2D version. This idea could be used for an icon for the Noise class. |
I get you, but that's not what I'm saying. I'm saying I want to remain similar to this: Anyway, next take, what do you think? It's not grid-aligned, that's impossible, but hopefully it's distinct enough to make up for it. I personally like old ImageTexture3D more for sure, and honestly I also like the cubes more. |
I'm not too strict about the grid, sometimes not making things grid-aligned allows you to make them larger, and therefore clearer. Do you have the SVG of your example? I'm pretty on board with the idea of keeping the 3D-ness, but only as an "easter egg" while the front faces are big enough to look comparable to NoiseTexture2D's squares. I'll test it later though |
Could we merge this as is, anyway? I'm pretty set on doing a follow-up PR exploring the Noise-related classes, so I could explore more alt designs there, it'd also allow me to maybe change up NoiseTexture2D. |
#79722 @WhalesState I used the jaggy line here. |
the jaggy lines looks cool. |
The NoiseTexture3D icon is a bit difficult to make out if you don't know where does it come from. |
Alrighty, seems to be what everyone thinks, so I'll do another take on this one! |
314851f
to
414cbe2
Compare
414cbe2
to
3510b6e
Compare
Haven't changed anything important in this push, I'm still using the initial designs. Can't make anything I like more. And honestly I feel quite restricted on a PR that's about texture cubes, rather than Noise-related icons. Meanwhile the PR that uses a jaggy line for FastNoiseLite also is getting a bit of a pushback, since the library doesn't have you think about noise functions and a jaggy line is not a familiar association. So let's pls refine later, I could try to make a PR that re-imagines all three icons in a way that's consistent once this gets in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! |
Oh, and the old Texture3D icon is deleted. Its style clashed with the one I went for here, also it's an abstract class so an icon isn't that important. Texture2D hasn't got one for example