Do not change a node unique name to the same name #78925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you rename node to an empty name, it will become blank: godot.windows.editor.dev.x86_64_HM839ONQmu.mp4Only happens with unique name nodes. You probably need to restore previous text. |
theraot
force-pushed
the
fix_rename_unique
branch
from
aa4227b to
b2bef8c
Compare
akien-mga
added
the
cherrypick:4.1
KoBeWi
approved these changes
Jul 7, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78922
Fixes #79085
The code already attempted to get a node by the new name to check if there was a different existing node with a unique name matching the name. I have added a check to see if the node it finds is the same being renamed, in which case the operation is aborted silently.