Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression with GDScript enum descriptions now showing up in documentation #78953

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fix regression with GDScript enum descriptions now showing up in documentation #78953

merged 1 commit into from
Jul 7, 2023

Conversation

anvilfolk
Copy link
Contributor

Didn't show up before, does now :)

@anvilfolk anvilfolk requested a review from a team as a code owner July 2, 2023 15:12
@anvilfolk anvilfolk marked this pull request as draft July 2, 2023 15:19
@anvilfolk anvilfolk marked this pull request as ready for review July 2, 2023 15:30
@AThousandShips AThousandShips added this to the 4.2 milestone Jul 2, 2023
@AThousandShips AThousandShips added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 2, 2023
dalexeev
dalexeev approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works right, it was just an oversight. Thank you for the quick response and fix!

@anvilfolk
Copy link
Contributor Author

Looks good and works right, it was just an oversight. Thank you for the quick response and fix!

Thanks for finding it! :)

@akien-mga akien-mga merged commit b3c2b52 into godotengine:master Jul 7, 2023
@akien-mga
Copy link
Member

Thanks!

@anvilfolk anvilfolk deleted the enum-desc branch July 7, 2023 12:06
@YuriSizov YuriSizov changed the title Fix regression with GDScript enum descriptions now showing up in documentation. Fix regression with GDScript enum descriptions now showing up in documentation Jul 10, 2023
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev dalexeev approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug documentation regression topic:gdscript
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@anvilfolk @akien-mga @YuriSizov @dalexeev @AThousandShips