Take eye offset into account for depth in StandardMaterial3D #79049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
added
bug
topic:rendering
topic:xr
cherrypick:4.1
akien-mga
reviewed
Jul 5, 2023
BastiaanOlij
force-pushed
the
fix_stereo_depth_paralax
branch
from
7993c0b
to
581d081
Compare
clayjohn
approved these changes
Jul 6, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using depth in
StandardMaterial3Dthe eye offset wasn't taken into account giving the material a flat look when viewed in stereoscopic.Note that eye_offset is set to
vec3(0, 0, 0)for normal rendering and should just end up being ignored.Fixes #73404