-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextServer] Fix get_word_breaks
and its uses.
#79054
Conversation
get_word_breaks
and its uses.
@Rindbee Could you test these changes? Also maybe @timothyqiu could help? @bruvzg And could you rebase your PR so it runs fresh CI, since its been too long? 🙂 |
The stuttering of tts is gone. The results returned by English test text: "Godot Engine, the game engine you've been waiting for."
It is worth noting that the test results for the English text changed. Chinese test text: "天行健,君子以自强不息;地势坤,君子以厚德载物"
When |
Not sure if I see anything wrong with it, the difference is only in presence of space, English text breaks on punctuation since it can't fit the next word and a space, so behavior is the same for both. |
Thanks! |
Fixes #78646