Fix infinite loop state check in AnimationStateMachine
#79141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
added
bug
high priority
crash
cherrypick:4.1
TokageItLab
force-pushed
the
fix-infinity-state-loop
branch
from
036b144 to
79656d1
Compare
akien-mga
reviewed
Jul 7, 2023
|
How is the issue communicated to the user when such a potential infinite loop is detected? I see it breaks but doesn't raise an error (here at least, it maybe does further up the stack). Will users understand that their setup is non functional due to recursion? |
TokageItLab
force-pushed
the
fix-infinity-state-loop
branch
from
79656d1 to
d197a77
Compare
|
Perhaps the state continues to change every frame, but that is a normal transition and not an error. Since Nodes in StateMachine cannot have a path to itself, if this check works, there is no longer an infinite loop in the true sense of the word. |
TokageItLab
force-pushed
the
fix-infinity-state-loop
branch
from
d197a77 to
9948ba0
Compare
|
@akien-mga I've added a warning in case you're concerned.
|
TokageItLab
force-pushed
the
fix-infinity-state-loop
branch
3 times, most recently
from
72b4c34 to
7b66897
Compare
bruvzg
reviewed
Jul 7, 2023
akien-mga
reviewed
Jul 7, 2023
TokageItLab
force-pushed
the
fix-infinity-state-loop
branch
from
7b66897 to
fc40ba2
Compare
akien-mga
approved these changes
Jul 7, 2023
YuriSizov
changed the title
AnimationStateMachineAnimationStateMachine
|
Thanks! |
|
Cherry-picked for 4.1.1. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79012.
If only the first pass is stored and compared, the loop detection will fail if an infinite loop starts in the middle of the path. So, all transition paths must be stored and compared. Also, remove
is_state_changed = falseas it was actually wrong (state change occurs just before the try infinite loop).